When adding a favicon to your Xenforo forum or other forum the favicon goes into the root folder of the forum or website.
So upload your new favicon to the root folder of your xenforo and then if you still don't see the favicon in your browser then you may need to clear your browser cache and then reload the forum to see the favicon.