Killing weeds with vinegar takes around 3 days for the weeds to die after spraying them with the vinegar.
Vinegar takes a little longer to kill weeds than other weed killers but if you spray the weeds everyday for the 3 days with vinegar the weeds will die.
The more vinegar you spray on the weeds the faster the weeds will die so spray as much vinegar as you can everyday and in 3 days the weeds should be dead.
Vinegar is a more natural safer weed killer than commercially made weed killers and it's much better for the environment and safer for your health as well.
For a more effective weed killer you can add some dish soap such as dawn dish soap to the vinegar in the sprayer and spray the weeds with the dish soap and vinegar.
The dish soap will help kill the weeds much better than the vinegar by itself.